flag "--all" for command alt update #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beetsplug/alternatives.py contained whitespaces in blank line
wisp3rwind
reviewed
Nov 2, 2018
There was a problem hiding this comment.
Sounds like a useful feature to me, what do you think @geigerzaehler?
| alt = self.alternative(options.name, lib) | ||
| alts = [] | ||
| if options.all: | ||
| for key in self.config.keys(): |
There was a problem hiding this comment.
IMO, this would be more concisely written as a list comprehension
alts = [self.alternative(key, lib) for key in self.config]
|
Looks like a good addition to me, too. Would you like to continue with this @pkess? Before merging we would need documentation and tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
i think this command could be usefull as it simplifies an update of several alternative locations in a single command