Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert vite update #807

Merged
merged 4 commits into from
May 21, 2021
Merged

Revert vite update #807

merged 4 commits into from
May 21, 2021

Conversation

cquiroz
Copy link
Contributor

@cquiroz cquiroz commented May 21, 2021

The build is not working in production. It seems related to
vitejs/vite#3312

In the meanwhile I'll downgrade vite and this also allows me to redo the use of react-hotkey to get esc to close the help

Signed-off-by: Carlos Quiroz <cquiroz@gemini.edu>
Signed-off-by: Carlos Quiroz <cquiroz@gemini.edu>
Signed-off-by: Carlos Quiroz <cquiroz@gemini.edu>
Signed-off-by: Carlos Quiroz <cquiroz@gemini.edu>
Copy link
Contributor

@rpiaggio rpiaggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cquiroz cquiroz merged commit 5a0bf69 into master May 21, 2021
@cquiroz cquiroz deleted the revert-vite-update branch May 21, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants