Update dependencies (particularly crc 3.0.0) #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chyyran
force-pushed
the
patch-update-crc
branch
3 times, most recently
from
a11e8d9
to
110700b
Compare
chyyran
commented
Aug 9, 2022
gendx
requested changes
Aug 23, 2022
chyyran
force-pushed
the
patch-update-crc
branch
2 times, most recently
from
c6704c1
to
e51f885
Compare
|
Addressed the nits and rebased on master. See follow up comment on reasoning for |
1 task
gendx
requested changes
Aug 26, 2022
chyyran
force-pushed
the
patch-update-crc
branch
from
e51f885
to
4d800af
Compare
chyyran
force-pushed
the
patch-update-crc
branch
from
4d800af
to
7f8d36f
Compare
|
In the meantime I've merged #82 which addresses the import formatting question. Could you rebase on top of it to resolve the merge conflict? |
chyyran
force-pushed
the
patch-update-crc
branch
from
7f8d36f
to
698620b
Compare
|
Rebased on master in 698620b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request adds/changes/fixes...
byteorderto1.4.3logto0.4.17env_loggerto0.9.0crcto3.0.0crcfrom^1.0.0->3.0.0represents a very large API change. In particular, algorithms are now const-initialized andDigestno longer implementsHash, soWrite/ReadforDigestWrite/Read(formerlyHasherWrite/Read) has to be implemented per type. This results in most of the code changes in this PR.crcand the XZ specification. See CRC-64/XZ and and CRC-32/ISO-HDLC in the catalogue of parameterised CRC algorithms.Testing Strategy
This pull request was tested by ...