Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Add pagination to tags page #89 #116

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

knopka
Copy link

@knopka knopka commented Jul 20, 2018

No description provided.

Copy link
Contributor

@jstoja jstoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not manage to make it work because of static templates that are not fetch, any idea why @knopka ?


"github.com/genuinetools/reg/clair"
"github.com/genuinetools/reg/registry"
"github.com/gorilla/mux"
"github.com/sirupsen/logrus"
"github.com/knopka/go-pagination-bootstrap"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this import. I'm not sure having an external import that renders HTML that is from outside this repository is the way to go, but I might be wrong.

}

.pagination a {
font-size: small;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's one indent too much ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants