Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 4168 - Console - RGPD "export my data" - Geonetwork on an other database #4189

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

pierrejego
Copy link
Member

@pierrejego pierrejego commented Feb 15, 2024

This PR add a new datasource to connect to geonetwork database.

New fields have to be added in console.properties :

PostGreSQL database connection parameters to geonetwork

pgsqlGNHost
pgsqlGNPort
pgsqlGNDatabase
pgsqlGNUser
pgsqlGNPassword

PR will be done for those new params in datadir and ansible.

@pierrejego pierrejego changed the title Issue 4168 - Geonetwork on a other database Issue 4168 - Geonetwork on an other database Feb 15, 2024
@f-necas f-necas self-requested a review February 15, 2024 14:10
@landryb landryb linked an issue Feb 19, 2024 that may be closed by this pull request
@landryb
Copy link
Member

landryb commented Feb 19, 2024

fwiw those ds->dataSource changes seem gratuitous and unneeded .. no ?

@pierrejego
Copy link
Member Author

fwiw those ds->dataSource changes seem gratuitous and unneeded .. no ?

No it needed by Spring because two datasource beans are declared in configuration. Each field must have the same field name as an object and in configuration. Otherwise application won't start

@landryb
Copy link
Member

landryb commented Feb 19, 2024

such voodoo :)

@pmauduit pmauduit changed the title Issue 4168 - Geonetwork on an other database Issue 4168 - Console - RGPD "export my data" - Geonetwork on an other database Feb 19, 2024
Copy link
Contributor

@f-necas f-necas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about default values ? Don't know if we can set something like ${pgsqlGNHost:pgsqlHost} to avoid duplicating values in console.properties.

And we will need a PR in georchestra/datadir with it.

@pierrejego
Copy link
Member Author

What about default values ? Don't know if we can set something like ${pgsqlGNHost:pgsqlHost} to avoid duplicating values in console.properties.

Yes I can do this, good idea for default value

And we will need a PR in georchestra/datadir with it.

Yes this is needed, but Integration test are not working on geonetwork and I didn't had time to look. Once Integration Test is fixed I will to the datadir and ansible PR as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ CONSOLE ] RGPD en erreur ( cas d'installation particulier )
3 participants