For Discussion: Adding functionality to allow mutating an iterator of coordinates in place #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Thanks @frewsxcv , Let's not merge it just yet. I've been working on the other side of the problem (having geometries generate an iterator that yield mutable references to coordinates) and have run into some major lifetime issues that might be insurmountable without either GATs or unsafe. I'll post more about that once I have it more clear in my mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pursuant to the discussion here (georust/geo#718) , I've been playing with the idea of converting / projecting Iterators of mutable coordinates.
This should allow us to convert large geometries with a single-call to Proj.
If folks are amenable to this approach, I'll work on implementing
Iterator<Item = &'a mut Coord<CoordinateType>>forgeo-types.