Performed refactoring the code by doing pull-down method #2451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function has 3 problems: 1) It is a complex method where Cyclomatic complexity is 29, 2) There are duplicate blocks of code and 3) It is a long method with lines of code equals to 110. Two new methods are created after this refactorization process which is collectColorSamples and getClosestColorSamples.
…ngNodeSizeTransformer and RankingLabelSizeTransformer extended class RankingSizeTransformer. In both child classes, they are implementing the same isNode method with the same implementation. As it is promoting duplicate code, it is always better to put the duplicate code in the parent class so that all other classes that uses this parent class can utilize this method without re-writing it.
…face is bulky (a large number of public methods). The goal of extracting XML methods from this class was not only to solve the above smell, but also to ensure that this class adhered to the "single responsibility concept."
…ild classes. I pushed down the relax method to the child class (BellmanFordShortestPathAlgorithm) and removed it from the parent class to avoid an unwanted duplication of a method in the child class where it is not utilised at all (DijkstraShortestPathAlgorithm)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "relax method" of the parent class is unnecessarily inherited by both child classes. To avoid an undesired duplication of a method in the child class where it is not used at all, I transferred the "relax method" to the child class (BellmanFordShortestPathAlgorithm) and removed it from the parent class (DijkstraShortestPathAlgorithm)