#2842 Don't draw invalid svg paths for curved edges #2844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanal
force-pushed
the
github2842
branch
2 times, most recently
from
dd01a47
to
016425d
Compare
- Don't draw edge when completely truncated. - computeThatThing condition previously never failed as rt is negative - Pass arc angle to computeThatThing for extra precision - Return large negative value so we know edge is totally truncated - Don't reposition edge labels when edge totally truncated - Add edge label edge case for two nodes in the same position - Don't change angle of arrow if edge totally truncated (avoid NaN in polyline) - Add "unit" test for svg export of edge cases. Added to PreviewExport, not PreviewPlugin, to avoid relying on details of plugin set up. Downside: pdf isn't easily tested as exceptions are caught too early.
nathanal
force-pushed
the
github2842
branch
from
5a78f17
to
2d3ebe6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix svg output in #2842 (one node is inside another) by not drawing the edge when it is truncated too much.
Previously, computeThatThing's condition never failed, as rt was only passed when negative. We now pass the arc length and return a large negative angle if it fails. This should register as excessive truncative and be marked not to be drawn.
Used #2608 and a jumping off point in investigation.
Checklist
Added tests?
Simple (but big) gexf file to test some cases testing.zip. It got a bit out of hand, but wasn't too smart (just a straight up permutation of various angles, distances, sizes). Smaller version of the above zip extended_alldir.zip
Nearly all cases can be considered edge cases (i.e. overlapping nodes).
I've pushed a sample of the above examples cases into a unit test.
Added to documentation?
Update: the force push was just squashing my commits together