Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nginx: added some security related configs #3330

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

makuhama
Copy link

added an extra rule to deal with ACME challenges
added another rule to allow caching for some static content
added an alternative how to deal with PHP scripts (uwsgi)

added an extra rule to deal with ACME challenges
added another rule to allow caching for some static content
@mahagr mahagr changed the title added some security related configs nginx: added some security related configs Apr 26, 2021
@mahagr mahagr requested a review from rhukster April 26, 2021 06:34
Comment on lines 19 to 27
## Begin - ACME (LetsEncrypt)
# adapt the root folder to where your certification job (e.g. CertBot)
# puts the domain verification challenges
location ^~ /.well-known/acme-challenge/ {
root /srv/http/acme;
rewrite ^/\.well-known/acme-challenge/(.*)$ /$1 break;
}
## End - ACME (LetsEncrypt)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be commented out if optional?

Comment on lines 60 to 65
# or if you use uwsgi
location ~ \.php$ {
include uwsgi_params;
uwsgi_modifier1 14;
uwsgi_pass unix:/run/uwsgi/grav.sock;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel this is great but should be commented out as it's optional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants