Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: option to show user for Tautulli and Emby/Jellyfin widgets #3287

Merged
merged 6 commits into from
Apr 13, 2024

Conversation

brikim
Copy link
Contributor

@brikim brikim commented Apr 13, 2024

Proposed change

Added a new optional flag that can be added to the widget enableUser. If true the username will be added in parenthesis behind the title. Updated the documentation stating that this is an optional field and defaults to false.

TautulliEmbyJellyfinUsername
TautulliJellyfinEnableUserConfig

Closes #1233 #151

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation only
  • Other (please explain)

Checklist:

  • If applicable, I have added corresponding documentation changes.
  • If applicable, I have reviewed the feature and / or service widget guidelines.
  • I have checked that all code style checks pass using pre-commit hooks and linting checks.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

…gets. If enableUser flag is defined and set to true the user name will be displayed behind the title in parenthesis. Title (UserName).
@brikim
Copy link
Contributor Author

brikim commented Apr 13, 2024

take 2 ... sorry about that I have no idea what was going on with my fork. Also if you would like me to remove the Emby/Jellyfin I can since the feature requests were just for Tautulli. I just added it to that widget for consistency. Thanks

src/utils/config/service-helpers.js Outdated Show resolved Hide resolved
src/utils/config/service-helpers.js Outdated Show resolved Hide resolved
src/widgets/emby/component.jsx Outdated Show resolved Hide resolved
src/widgets/tautulli/component.jsx Outdated Show resolved Hide resolved
@shamoon shamoon changed the title Added the ability to enableUser on the Tautulli and Emby/Jellyfin wid… Enhancement: option to show user for Tautulli and Emby/Jellyfin widgets Apr 13, 2024
brikim and others added 4 commits April 12, 2024 22:12
Co-authored-by: shamoon <4887959+shamoon@users.noreply.github.com>
Co-authored-by: shamoon <4887959+shamoon@users.noreply.github.com>
Co-authored-by: shamoon <4887959+shamoon@users.noreply.github.com>
Co-authored-by: shamoon <4887959+shamoon@users.noreply.github.com>
@brikim
Copy link
Contributor Author

brikim commented Apr 13, 2024

I applied the comments and retested and everything is still working as expected. Sorry I think I pulled that from another example. I tested the cases with no label in my services file and it wasn't showing username before not sure how that was working.

@brikim brikim requested a review from shamoon April 13, 2024 03:19
@shamoon shamoon enabled auto-merge (squash) April 13, 2024 03:32
Copy link
Collaborator

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, thanks

@shamoon shamoon merged commit bfd3920 into gethomepage:main Apr 13, 2024
5 checks passed
szinn pushed a commit to szinn/k8s-homelab that referenced this pull request Apr 17, 2024
… v0.8.12 ) (#3477)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[ghcr.io/gethomepage/homepage](https://togithub.com/gethomepage/homepage)
| patch | `v0.8.11` -> `v0.8.12` |

---

### Release Notes

<details>
<summary>gethomepage/homepage (ghcr.io/gethomepage/homepage)</summary>

###
[`v0.8.12`](https://togithub.com/gethomepage/homepage/releases/tag/v0.8.12)

[Compare
Source](https://togithub.com/gethomepage/homepage/compare/v0.8.11...v0.8.12)

#### What's Changed

- Enhancement: option to show user for Tautulli and Emby/Jellyfin
widgets by [@&#8203;brikim](https://togithub.com/brikim) and
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3287
- Fix: pihole `ads_percentage_today` sometimes returned as string by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3313

#### New Contributors

- [@&#8203;brikim](https://togithub.com/brikim) made their first
contribution in
[gethomepage/homepage#3287

**Full Changelog**:
gethomepage/homepage@v0.8.11...v0.8.12

</details>

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMDIuMCIsInVwZGF0ZWRJblZlciI6IjM3LjMwMi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL3BhdGNoIl19-->

Co-authored-by: repo-jeeves[bot] <106431701+repo-jeeves[bot]@users.noreply.github.com>
truecharts-admin added a commit to truecharts/charts that referenced this pull request Apr 17, 2024
…0.8.12@ad5a8ed by renovate (#20908)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[ghcr.io/gethomepage/homepage](https://togithub.com/gethomepage/homepage)
| patch | `v0.8.11` -> `v0.8.12` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>gethomepage/homepage (ghcr.io/gethomepage/homepage)</summary>

###
[`v0.8.12`](https://togithub.com/gethomepage/homepage/releases/tag/v0.8.12)

[Compare
Source](https://togithub.com/gethomepage/homepage/compare/v0.8.11...v0.8.12)

#### What's Changed

- Enhancement: option to show user for Tautulli and Emby/Jellyfin
widgets by [@&#8203;brikim](https://togithub.com/brikim) and
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3287
- Fix: pihole `ads_percentage_today` sometimes returned as string by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3313

#### New Contributors

- [@&#8203;brikim](https://togithub.com/brikim) made their first
contribution in
[gethomepage/homepage#3287

**Full Changelog**:
gethomepage/homepage@v0.8.11...v0.8.12

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMDMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjMwMy4yIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbImF1dG9tZXJnZSIsInVwZGF0ZS9kb2NrZXIvZ2VuZXJhbC9ub24tbWFqb3IiXX0=-->
github-merge-queue bot pushed a commit to chezmoi-sh/atlas that referenced this pull request Apr 20, 2024
…76)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change | OpenSSF |
|---|---|---|---|
| [gethomepage/homepage](https://togithub.com/gethomepage/homepage) |
patch | `v0.8.11` -> `v0.8.12` | [![OpenSSF
Scorecard](https://api.securityscorecards.dev/projects/github.com/gethomepage/homepage/badge)](https://securityscorecards.dev/viewer/?uri=github.com/gethomepage/homepage)
|

---

### Release Notes

<details>
<summary>gethomepage/homepage (gethomepage/homepage)</summary>

###
[`v0.8.12`](https://togithub.com/gethomepage/homepage/releases/tag/v0.8.12)

[Compare
Source](https://togithub.com/gethomepage/homepage/compare/v0.8.11...v0.8.12)

##### What's Changed

- Enhancement: option to show user for Tautulli and Emby/Jellyfin
widgets by [@&#8203;brikim](https://togithub.com/brikim) and
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3287
- Fix: pihole `ads_percentage_today` sometimes returned as string by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3313

##### New Contributors

- [@&#8203;brikim](https://togithub.com/brikim) made their first
contribution in
[gethomepage/homepage#3287

**Full Changelog**:
gethomepage/homepage@v0.8.11...v0.8.12

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/chezmoi-sh/nex.rpi).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMDEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjMwMS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants