Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: pihole ads_percentage_today sometimes returned as string #3313

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Conversation

shamoon
Copy link
Collaborator

@shamoon shamoon commented Apr 16, 2024

Proposed change

Screenshot 2024-04-16 at 3 44 24 PM

Closes #3312

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation only
  • Other (please explain)

Checklist:

  • If applicable, I have added corresponding documentation changes.
  • If applicable, I have reviewed the feature and / or service widget guidelines.
  • I have checked that all code style checks pass using pre-commit hooks and linting checks.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

@shamoon shamoon merged commit 303a623 into main Apr 16, 2024
1 check passed
@shamoon shamoon deleted the fix-3312 branch April 16, 2024 22:50
szinn pushed a commit to szinn/k8s-homelab that referenced this pull request Apr 17, 2024
… v0.8.12 ) (#3477)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[ghcr.io/gethomepage/homepage](https://togithub.com/gethomepage/homepage)
| patch | `v0.8.11` -> `v0.8.12` |

---

### Release Notes

<details>
<summary>gethomepage/homepage (ghcr.io/gethomepage/homepage)</summary>

###
[`v0.8.12`](https://togithub.com/gethomepage/homepage/releases/tag/v0.8.12)

[Compare
Source](https://togithub.com/gethomepage/homepage/compare/v0.8.11...v0.8.12)

#### What's Changed

- Enhancement: option to show user for Tautulli and Emby/Jellyfin
widgets by [@&#8203;brikim](https://togithub.com/brikim) and
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3287
- Fix: pihole `ads_percentage_today` sometimes returned as string by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3313

#### New Contributors

- [@&#8203;brikim](https://togithub.com/brikim) made their first
contribution in
[gethomepage/homepage#3287

**Full Changelog**:
gethomepage/homepage@v0.8.11...v0.8.12

</details>

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMDIuMCIsInVwZGF0ZWRJblZlciI6IjM3LjMwMi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL3BhdGNoIl19-->

Co-authored-by: repo-jeeves[bot] <106431701+repo-jeeves[bot]@users.noreply.github.com>
truecharts-admin added a commit to truecharts/charts that referenced this pull request Apr 17, 2024
…0.8.12@ad5a8ed by renovate (#20908)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[ghcr.io/gethomepage/homepage](https://togithub.com/gethomepage/homepage)
| patch | `v0.8.11` -> `v0.8.12` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>gethomepage/homepage (ghcr.io/gethomepage/homepage)</summary>

###
[`v0.8.12`](https://togithub.com/gethomepage/homepage/releases/tag/v0.8.12)

[Compare
Source](https://togithub.com/gethomepage/homepage/compare/v0.8.11...v0.8.12)

#### What's Changed

- Enhancement: option to show user for Tautulli and Emby/Jellyfin
widgets by [@&#8203;brikim](https://togithub.com/brikim) and
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3287
- Fix: pihole `ads_percentage_today` sometimes returned as string by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3313

#### New Contributors

- [@&#8203;brikim](https://togithub.com/brikim) made their first
contribution in
[gethomepage/homepage#3287

**Full Changelog**:
gethomepage/homepage@v0.8.11...v0.8.12

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMDMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjMwMy4yIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbImF1dG9tZXJnZSIsInVwZGF0ZS9kb2NrZXIvZ2VuZXJhbC9ub24tbWFqb3IiXX0=-->
github-merge-queue bot pushed a commit to chezmoi-sh/atlas that referenced this pull request Apr 20, 2024
…76)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change | OpenSSF |
|---|---|---|---|
| [gethomepage/homepage](https://togithub.com/gethomepage/homepage) |
patch | `v0.8.11` -> `v0.8.12` | [![OpenSSF
Scorecard](https://api.securityscorecards.dev/projects/github.com/gethomepage/homepage/badge)](https://securityscorecards.dev/viewer/?uri=github.com/gethomepage/homepage)
|

---

### Release Notes

<details>
<summary>gethomepage/homepage (gethomepage/homepage)</summary>

###
[`v0.8.12`](https://togithub.com/gethomepage/homepage/releases/tag/v0.8.12)

[Compare
Source](https://togithub.com/gethomepage/homepage/compare/v0.8.11...v0.8.12)

##### What's Changed

- Enhancement: option to show user for Tautulli and Emby/Jellyfin
widgets by [@&#8203;brikim](https://togithub.com/brikim) and
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3287
- Fix: pihole `ads_percentage_today` sometimes returned as string by
[@&#8203;shamoon](https://togithub.com/shamoon) in
[gethomepage/homepage#3313

##### New Contributors

- [@&#8203;brikim](https://togithub.com/brikim) made their first
contribution in
[gethomepage/homepage#3287

**Full Changelog**:
gethomepage/homepage@v0.8.11...v0.8.12

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/chezmoi-sh/nex.rpi).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMDEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjMwMS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pihole widget error when ads_percentage_today is string type
1 participant