-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add setting to append ref
parameter to links in feeds
#3249
Conversation
Updated with documentation. |
rel
parameter to feeds
@justinmayer Is there any further work needed here or is this ready to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @GiovanH. My apologies for the delay in reviewing. I've looked at this several times, but something always felt… not quite right… but I could never put my finger on what didn’t feel right.
I think I figured it out:
- The
rel
attribute is for use within HTML documents. I don't think I have ever seen a?rel=[…]
URL parameter, and I can’t find any documentation about such a parameter anywhere on the Internet. I have, on the other hand, seen?ref=[…]
URL parameters used to indicating referrer information. Perhaps you meantref
and notrel
? If so, perhaps change the URL parameter, and also change the setting name toFEED_APPEND_REFERRER
? - For the parameter value, I suggest using the generic
feed
instead ofrss
, as a feed can be in either Atom or RSS format.
If I am wrong on any of the above counts, by all means feel free to point me to information to the contrary! 😊
I agree with you on both counts. |
rel
parameter to feedsref
parameter to feeds
ref
parameter to feedsref
parameter to links in feeds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the feature contribution, @GiovanH! ✨
This is a feature I'm experimenting with for personal use, as it's useful for analytics purposes to see if people are using the rss feeds.
This is more of a proposal at this stage. Is this something people would be interested in?