Validate upgrade action on build #3031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validate the upgrade action during `porter build`, otherwise it will only the validated when `porter upgrade` is executed. All other actions `install`, `uninstall` and custom actions are validated on `porter build` already. Signed-off-by: Kim Christensen <kimworking@gmail.com>
kichristensen
requested review from
schristoff,
sgettys,
bdegeeter and
troy0820
as code owners
sgettys
approved these changes
Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Validate the upgrade action during
porter build, otherwise it will only the validated whenporter upgradeis executed. All other actionsinstall,uninstalland custom actions are validated onporter buildalready.What issue does it fix
Closes #3030
Notes for the reviewer
The test introduced is using some pointers in order to make it more generic, making it a little harder to understand. I'm not 100% convinced myself it is a good idea, please let me know what you think.
Checklist
Reviewer Checklist