Cypress: Fix Stuck E2E test - create_query_spec

[gabrieldutra]

What type of PR is this? (check all applicable)

• Other

Description

After a bug that could be avoided by Percy (#3744) I took a time to investigate #3688. It turns out this was getting stuck due to the onbeforeunload confirm dialog 😪.

This fix is a workaround for cypress-io/cypress#2118

Related Tickets & Documents

Closes #3688

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

--

[ranbena]

@gabrieldutra is this relevant cause the query is left unsaved?

[gabrieldutra]

@gabrieldutra is this relevant cause the query is left unsaved?

I did think about saving the query instead, though I considered having a clean state afterwards. However from a second thought, it can be interesting to turn it into a "executes and saves a query" 🤔. I will change it here.

[ranbena]

I considered having a clean state afterwards.

Better to make sure tests are absolutely independent.

it can be interesting to turn it into a "executes and saves a query" 🤔. I will change it here.

Perfecto.
Too bad cy.route() doesn't work with redirects 😒

[gabrieldutra]

Better to make sure tests are absolutely independent.

Yep, but so far there are no apparent issues for Query pages :)

We should probably create a few more tests prior to the Query Page migration, so until then we can stand with this.