-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin importlib-metadata to 4.13.0 #5851
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5.0.0 removed SelectableGroups which Redash 10 depends on See python/importlib_metadata#409
vinodpandey
added a commit
to vinodpandey/redash
that referenced
this pull request
Nov 20, 2022
@eradman could you please assign reviewers for this PR to get their attention? @susodapop for instance, I think |
Since I'm an outside contributor I can't assign a reviewer. Thanks for pinging this ticket with an @ mention! |
This should be a fairly high priority PR. App fails startup without this fix. |
Latest checkout of Redash does not require this fix. Closing
|
guidopetri
pushed a commit
that referenced
this pull request
Jul 17, 2023
…rch Console API (#5868) * quick and dirty GA4 integration to support limited queries request pattern: { "propertyId": 123456789, "dateRanges": [{ "startDate": "yesterday", "endDate": "yesterday" }], "dimensions": [{ "name": "date" }], "metrics": [{ "name": "activeUsers" }] } * Update Dockerfile * Update requirements_bundles.txt related issue: #5851 https://stackoverflow.com/questions/73929564/entrypoints-object-has-no-attribute-get-digital-ocean * updated integration code to support all usecases for runReport endpoint (does not have support for runPivotReport yet) * added google search console as query runner * removed info logger * removed files that were causing merge conflicts * fixed failing testcases and pre-commit formatting changes * added testcases * fixed linting errors in test files * code optimization
EmilaineBorato
pushed a commit
to sondautilities/sonda_d4b_redash
that referenced
this pull request
Jul 24, 2023
…rch Console API (getredash#5868) * quick and dirty GA4 integration to support limited queries request pattern: { "propertyId": 123456789, "dateRanges": [{ "startDate": "yesterday", "endDate": "yesterday" }], "dimensions": [{ "name": "date" }], "metrics": [{ "name": "activeUsers" }] } * Update Dockerfile * Update requirements_bundles.txt related issue: getredash#5851 https://stackoverflow.com/questions/73929564/entrypoints-object-has-no-attribute-get-digital-ocean * updated integration code to support all usecases for runReport endpoint (does not have support for runPivotReport yet) * added google search console as query runner * removed info logger * removed files that were causing merge conflicts * fixed failing testcases and pre-commit formatting changes * added testcases * fixed linting errors in test files * code optimization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
importlib-metadata-5.0.0 removed SelectableGroups which Redash 10 depends on
See python/importlib_metadata#409
How is this tested?
Related Tickets & Documents
Solves https://discuss.redash.io/t/docker-installation-problem/11190