Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin importlib-metadata to 4.13.0 #5851

Closed
wants to merge 1 commit into from
Closed

Conversation

eradman
Copy link
Collaborator

@eradman eradman commented Nov 8, 2022

What type of PR is this?

  • Bug Fix

Description

importlib-metadata-5.0.0 removed SelectableGroups which Redash 10 depends on

See python/importlib_metadata#409

How is this tested?

  • Manually
docker-compose run --rm server create_db

Related Tickets & Documents

Solves https://discuss.redash.io/t/docker-installation-problem/11190

5.0.0 removed SelectableGroups which Redash 10 depends on

See python/importlib_metadata#409
@apollonin
Copy link
Contributor

@eradman could you please assign reviewers for this PR to get their attention? @susodapop for instance, I think

@eradman
Copy link
Collaborator Author

eradman commented Dec 21, 2022

Since I'm an outside contributor I can't assign a reviewer. Thanks for pinging this ticket with an @ mention!

@PatrickBig
Copy link

This should be a fairly high priority PR.

App fails startup without this fix.

@arikfr arikfr mentioned this pull request Feb 17, 2023
1 task
@eradman
Copy link
Collaborator Author

eradman commented Jul 3, 2023

Latest checkout of Redash does not require this fix. Closing

$ docker exec -i -t c6a26764490a pip3 list | grep importlib
importlib-metadata         6.7.0
importlib-resources        5.12.0

@eradman eradman closed this Jul 3, 2023
@eradman eradman deleted the build branch July 3, 2023 17:04
guidopetri pushed a commit that referenced this pull request Jul 17, 2023
…rch Console API (#5868)

* quick and dirty GA4 integration to support limited queries

request pattern:
{
   "propertyId": 123456789,
   "dateRanges": [{ "startDate": "yesterday", "endDate": "yesterday" }],
   "dimensions": [{ "name": "date" }],
   "metrics": [{ "name": "activeUsers" }]
}

* Update Dockerfile

* Update requirements_bundles.txt

related issue: 
#5851
https://stackoverflow.com/questions/73929564/entrypoints-object-has-no-attribute-get-digital-ocean

* updated integration code to support all usecases for runReport endpoint (does not have support for runPivotReport yet)

* added google search console as query runner

* removed info logger

* removed files that were causing merge conflicts

* fixed failing testcases and pre-commit formatting changes

* added testcases

* fixed linting errors in test files

* code optimization
EmilaineBorato pushed a commit to sondautilities/sonda_d4b_redash that referenced this pull request Jul 24, 2023
…rch Console API (getredash#5868)

* quick and dirty GA4 integration to support limited queries

request pattern:
{
   "propertyId": 123456789,
   "dateRanges": [{ "startDate": "yesterday", "endDate": "yesterday" }],
   "dimensions": [{ "name": "date" }],
   "metrics": [{ "name": "activeUsers" }]
}

* Update Dockerfile

* Update requirements_bundles.txt

related issue: 
getredash#5851
https://stackoverflow.com/questions/73929564/entrypoints-object-has-no-attribute-get-digital-ocean

* updated integration code to support all usecases for runReport endpoint (does not have support for runPivotReport yet)

* added google search console as query runner

* removed info logger

* removed files that were causing merge conflicts

* fixed failing testcases and pre-commit formatting changes

* added testcases

* fixed linting errors in test files

* code optimization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants