Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(self-hosted): recommend users to rerun install.sh for restart #1255

Merged

Conversation

aldy505
Copy link
Contributor

@aldy505 aldy505 commented Apr 28, 2024

Copy link

vercel bot commented Apr 28, 2024

@aldy505 is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

@stayallive
Copy link

I'm trying to think on how to formulate this better, but I feel like the current suggestion is a bit "soft" as in that it's more of a suggestion while instead it's more of an requirement. Especially if config has been changed.

What about smth more like:

After changing configuration files re-run the <code>./install.sh</code> script to rebuild and restart the containers. See the <Link to="/self-hosted/#configuration">configuration section</Link> for more information.

(I would also make them all the same, now there are 3/4 versions of exactly the same thing worded slightly different)

@azaslavsky
Copy link
Contributor

I'm trying to think on how to formulate this better, but I feel like the current suggestion is a bit "soft" as in that it's more of a suggestion while instead it's more of an requirement. Especially if config has been changed.

What about smth more like:

After changing configuration files re-run the <code>./install.sh</code> script to rebuild and restart the containers. See the <Link to="/self-hosted/#configuration">configuration section</Link> for more information.

(I would also make them all the same, now there are 3/4 versions of exactly the same thing worded slightly different)

Agreed on both counts. We should replicate the exact same callout, and use language like "strongly recommended".

@aldy505
Copy link
Contributor Author

aldy505 commented May 1, 2024

What about now? @stayallive @azaslavsky

Copy link
Contributor

@azaslavsky azaslavsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aldy505
Copy link
Contributor Author

aldy505 commented May 10, 2024

Ping @hubertdeng123

Copy link

vercel bot commented May 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 10:21pm

@hubertdeng123 hubertdeng123 merged commit 68ee307 into getsentry:master May 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better suggest to re-run ./install.sh rather than restarting Docker Compose after making changes
4 participants