This repository has been archived by the owner on Aug 30, 2023. It is now read-only.
84 return errors on capturing failure #161
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any comments / change requests on this, @mattrobenolt? Have you had time to look at it yet? |
|
Bump. |
|
ping @mattrobenolt. |
The client's capture method returns an error channel that according to the docs is intended to be used for checking if a packet was sent successfully whenever that is important. The `...AndWait` methods use this channel, but only to wait. They do not capture the possible error coming from that channel. The changes in this commit suggest to use the error and return it, so that a user may check whether a packet was sent successfully using new top level methods, instead of having to write their own. The newly introduced methods follow the naming scheme `Capture$SOMETHINGAndConfirm`, where the returned error is considered confirmation. Work on getsentry#84
valentin-krasontovitsch
force-pushed
the
84_return_errors_on_capturing_failure
branch
from
4a73d8e
to
c227fda
Compare
|
why is there no reaction? is this repo dead? will you provide the possibility of someone else taking over, as the current developer(s) obviously don't use enough time to maintain the project? @mattrobenolt don't mean to be cheeky, but getting a bit upset over being ignored... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add methods that return error when capturing
The client's capture method returns an error channel that according to
the docs is intended to be used for checking if a packet was sent
successfully whenever that is important.
The
...AndWaitmethods use this channel, but only to wait. They donot capture the possible error coming from that channel.
The changes in this commit suggest to use the error and return it, so
that a user may check whether a packet was sent successfully using new top
level methods, instead of having to write their own.
The newly introduced methods follow the naming scheme
Capture$SOMETHINGAndConfirm, where the returned error is consideredconfirmation.
Work on #84