use the stacktrace of cause, if that doesn't have one, use the one fr…

[femaref]

…om err

#215

[dcramer]

This seems like a fairly straightforward improvement. Would it be possible to add a test covering the error case?

[femaref]

oh, right. I just saw that there is a reference I missed in http.go. I'll add that. Or are you talking about something different?

[dcramer]

I mean test coverage in general- a test proving the change does what it suggests to ensure future changes maintain or improve upon the behavior.

[femaref]

sure, will do.

[jotto]

This is a high value change.

Without this change, as far as I can tell, reporting errors via raven.CaptureError at the top of a callstack will lose their original pkgErrors.Wrap stacktrace.

[femaref]

yes, that is exactly what is happening.

[jotto]

@femaref do you mind pushing your http fix, at least to your repo? I'd like to use your branch instead of creating another one

[femaref]

will do once I'm back at my notebook.

[femaref]

@jotto actually, it's part of the refactor branch: https://github.com/femaref/raven-go/blob/refactor/transport.go

[jotto]

thank you @femaref

is there an intent with the refactor beyond addressing the stacktrace issue?

[femaref]

yes, there is a lot of duplicate code between Capture* and Capture*WithWait. I'm reducing that duplication.