feat: Remove autoplay attribute from audio/video tags
#59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These can lead to weird results when replaying this later, so we just want to omit these.
billyvg
reviewed
Feb 22, 2023
| @@ -7,7 +7,7 @@ | |||
| <title>video</title> | |||
| </head> | |||
| <body> | |||
| <video controls> | |||
There was a problem hiding this comment.
Should we expect a snapshot file diff?
There was a problem hiding this comment.
No, because we are removing the autoplay attribute :D the snapshot changes without the change (which is expected), so IMHO the fact that this stays static is basically the test for this.
billyvg
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These can lead to weird results when replaying this later, so we just want to omit these.
ref: getsentry/sentry-javascript#6602 (comment)