Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not pollute build classpath #660

Merged
merged 3 commits into from Feb 24, 2024
Merged

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Feb 23, 2024

馃摐 Description

Seems like dev.gradleplugins:gradle-api was bundled with the plugin for compatibility reasons, removing the compatibility block fixes it

Before

image

After

image

馃挕 Motivation and Context

Closes #656

馃挌 How did you test it?

./gradlew build --scan

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

馃敭 Next steps

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@romtsn romtsn merged commit 604efbc into main Feb 24, 2024
18 checks passed
@romtsn romtsn deleted the rz/fix/polluted-build-classpath branch February 24, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrading to 4.3.0 adds multiple test dependencies to root project class path.
2 participants