Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make generating tasks cacheable #664

Merged
merged 8 commits into from Feb 28, 2024
Merged

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Feb 27, 2024

馃摐 Description

  • Add @CacheableTask annotation to tasks that generate something based on inputs from other tasks/files
  • Rework the SentryGenerateIntegrationList task a bit so it receives the integrations set as input instead of the entire SentryModulesService which allowed make it cacheable as well

馃挕 Motivation and Context

Closes #653

馃挌 How did you test it?

Manually + autoamted

馃摑 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

馃敭 Next steps

Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romtsn romtsn merged commit 74d8793 into main Feb 28, 2024
18 checks passed
@romtsn romtsn deleted the rz/fix/generate-debug-props-cacheable branch February 28, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generateSentryDebugMetaProperties cache busts by adding a timestamp to the sentry-meta-debug.properties
2 participants