publish with craft #261
publish with craft #261
Conversation
|
@marandaneto still missing the |
|
When adding the code to publish artifacts to zeus I realized the following:
Packages are not self contained. And the name of the pom file doesn't include the name of the package it relates to. So we could rename each of the files by prepending the package name but I'm not yet sure there's any easy way to upload the I noticed we're not publishing anything to maven central yet. Whatever we do here has to be with the end result of having this stuff on jcenter and maven central. |
| val version = "2.0.0-rc03" // updated by craft | ||
| val description = "SDK for sentry.io" | ||
| // TODO: change version code to publish new version, follow the pattern of `version` | ||
| val buildVersionCode = 20014 | ||
| val buildVersionCode = 20014 // updated by craft |
There was a problem hiding this comment.
I'd recommend moving these properties away from here to https://github.com/getsentry/sentry-android/blob/master/gradle.properties
There was a problem hiding this comment.
What is the benefit?
There was a problem hiding this comment.
not much tbh, it's a key/value props file and it'd be easier to change with a CLI tool
| # Add the new version | ||
| sed -i '' -e "s/val version = \"\(.*\)\" \/\/ updated by craft/val version = \"$NEW_VERSION\" \/\/ updated by craft/g" buildSrc/src/main/java/Config.kt | ||
| # Increment the buildVersionCode | ||
| perl -pi -e 's{val buildVersionCode = (\d+) // updated by craft}{$n=$1+1; "val buildVersionCode = $n // updated by craft"}e' buildSrc/src/main/java/Config.kt |
There was a problem hiding this comment.
buildVersionCode could be a hash from current date + incremental value, so it's easier to track. like sentry's semverish suggest, what do you think?
| zeus upload -t "application/zip+aar" ./*/build/outputs/aar/*release.aar | ||
| zeus upload -t "application/zip+jar" ./*/build/libs/*release.jar |
There was a problem hiding this comment.
what's about poms? eg
build/publications/release/pom-default.xml
or even *javadocs.jar, *sources.jar?
There was a problem hiding this comment.
The jars are all match the pattern. The pom is not because their names are all the same. I mentioned on slack. Wither we rename or find another way
There was a problem hiding this comment.
true about the pom files, but not for sources and javadocs files as they have a *-sources.jar and *-javadocs.jar pattern if I recall it well.
|
@marandaneto Are we publishing using the artifacts? |
No description provided.