run sample app and do a simple E2E test #451
Conversation
|
|
||
| env: | ||
| CMAKE_VERSION: "3.10.2.4988404" | ||
| NDK_VERSION: "21.0.6113669" |
There was a problem hiding this comment.
| NDK_VERSION: "21.0.6113669" | |
| NDK_VERSION: "21.2.6472646" |
github actions has this installed
There was a problem hiding this comment.
we have a fixed version on the build file
https://github.com/getsentry/sentry-android/blob/master/sentry-android-ndk/build.gradle.kts#L41
21.2.x is not available on LGTM GH App. yet.
marandaneto
changed the title
| - uses: malinskiy/action-android/emulator-run-cmd@release/0.0.7 | ||
| with: | ||
| cmd: make runConnectedTests | ||
| api: 25 |
There was a problem hiding this comment.
ideally making a matrix here
| // .baseUrl("https://sentry.io/") | ||
| // .client(OkHttpClient.Builder().addInterceptor { chain -> | ||
| // // token from https://sentry.io/settings/account/api/auth-tokens/ | ||
| // val request = chain.request().newBuilder().addHeader("Authorization", "Bearer ${TOKEN}}").build() |
There was a problem hiding this comment.
@bruno-garcia do you know if its possible to generate a token on demand? cus we can't read from a system env as this runs on the emulator.
also, it's not "nice" to leak the token on the code, Reverse engineering is too easy at this point.
There was a problem hiding this comment.
How would we get the generated token?
I agree it's not ideal to embed the key in the apk. We should be able to provide an apk alone and test it out since the testing code is not part of the apk
馃摙 Type of change
馃摐 Description
馃挕 Motivation and Context
馃挌 How did you test it?
馃摑 Checklist
馃敭 Next steps