docs(hub): 📝 multi-hub integrations setup #1689
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HazAT this looks right-ish to me. Can you confirm? |
HazAT
requested changes
Jun 10, 2020
Comment on lines
+100
to
102
| client2.setupIntegrations(); | ||
|
|
||
| const hub2 = new Sentry.Hub(client2); |
There was a problem hiding this comment.
Suggested change
| client2.setupIntegrations(); | |
| const hub2 = new Sentry.Hub(client2); | |
| const hub2 = new Sentry.Hub(); | |
| hub2.bindClient(client2); |
There was a problem hiding this comment.
This is actually a bug, we should call bindClient in the Hub constructor. cc @kamilogorek
Comment on lines
+88
to
90
| client1.setupIntegrations(); | ||
|
|
||
| const hub1 = new Sentry.Hub(client1); |
There was a problem hiding this comment.
Suggested change
| client1.setupIntegrations(); | |
| const hub1 = new Sentry.Hub(client1); | |
| const hub1 = new Sentry.Hub(client1); | |
| hub1.bindClient(client1); |
|
We can close this in favor of: getsentry/sentry-javascript#2665 Thx anyway for bringing this up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.