Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add retrieving Transaction #1775

Merged
merged 4 commits into from Jul 3, 2020
Merged

feat: Add retrieving Transaction #1775

merged 4 commits into from Jul 3, 2020

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented Jun 23, 2020

@HazAT HazAT self-assigned this Jun 23, 2020
@HazAT
Copy link
Member Author

HazAT commented Jun 29, 2020

We need to rebase this, the SDK docs have moved into their own page.

@@ -530,6 +534,24 @@ function processItem(item, transaction) {
}
```

#### Retrieving a Transaction
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same heading appearing multiple times in the same page (3x in this page) will all generate the same anchor link.

Do we have some helper to customize the anchor name? We could use that to make those 3 headings use different anchors.

@HazAT
Copy link
Member Author

HazAT commented Jul 1, 2020

I rebased the PR ontop of master

@kamilogorek kamilogorek self-requested a review July 1, 2020 13:21
@HazAT
Copy link
Member Author

HazAT commented Jul 1, 2020

There is still a todo and we need to release python so we can't merge this yet

@rhcarvalho
Copy link
Contributor

Filled in Python TODOs.

@HazAT HazAT merged commit a941181 into master Jul 3, 2020
@HazAT HazAT deleted the performance/sdk-docs branch July 3, 2020 12:17
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants