New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add performance docs for react #1792
Conversation
076a98b
to
b7a9a6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggested edits. 🌻 Thanks for helping with docs!
src/collections/_documentation/performance-monitoring/configuration/react.md
Outdated
Show resolved
Hide resolved
src/collections/_documentation/performance-monitoring/configuration/react.md
Outdated
Show resolved
Hide resolved
src/collections/_documentation/performance-monitoring/configuration/react.md
Outdated
Show resolved
Hide resolved
src/collections/_documentation/performance-monitoring/configuration/react.md
Outdated
Show resolved
Hide resolved
src/collections/_documentation/performance-monitoring/configuration/react.md
Outdated
Show resolved
Hide resolved
src/collections/_documentation/performance-monitoring/configuration/react.md
Outdated
Show resolved
Hide resolved
src/collections/_documentation/performance-monitoring/configuration/react.md
Outdated
Show resolved
Hide resolved
src/collections/_documentation/performance-monitoring/configuration/react.md
Outdated
Show resolved
Hide resolved
src/collections/_documentation/performance-monitoring/configuration/react.md
Outdated
Show resolved
Hide resolved
src/collections/_documentation/performance-monitoring/configuration/react.md
Outdated
Show resolved
Hide resolved
src/collections/_documentation/performance-monitoring/configuration/react.md
Outdated
Show resolved
Hide resolved
src/collections/_documentation/performance-monitoring/configuration/react.md
Show resolved
Hide resolved
Co-authored-by: Alberto Leal <mail4alberto@gmail.com> Co-authored-by: Tien "Mimi" Nguyen <tienmiminguyen@gmail.com>
Thank you for the review @MimiDumpling and @dashed. Here is what the page looks like now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Abhi!
This PR adds performance docs for React. It walks through using the
@sentry/react
package and the Profiler to add React related spans to transactions.