Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Docs for new Redux integration in @sentry/react #1881

Merged
merged 7 commits into from Jul 21, 2020

Conversation

jennmueng
Copy link
Member

Documentation for the new Redux integration included in @sentry/react: getsentry/sentry-javascript#2717

Currently as it is part of the @sentry/react package we include it on the React page for now.

@jennmueng jennmueng requested review from MimiDumpling, HazAT, AbhiPrasad and kamilogorek and removed request for MimiDumpling July 13, 2020 10:13
Copy link
Contributor

@MimiDumpling MimiDumpling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌻 Thanks for updating docs, Jenn! I made a couple suggested edits. Happy to discuss if you want.


### Normalization Depth

By default Sentry SDKs normalize any context to a depth of 3, which in the case of sending Redux state you probably will want to increase that. You do so by passing `normalizeDepth` to the `Sentry.init` call:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which in the case of sending Redux state you probably will want to increase that.

This sentence sounds kind odd, but I might be wrong. Can you take a look at it @MimiDumpling ?

Co-authored-by: Kamil Ogórek <kamil.ogorek@gmail.com>
@jennmueng jennmueng merged commit 0133f21 into master Jul 21, 2020
@jennmueng jennmueng deleted the feat/redux-docs branch July 21, 2020 13:48
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants