feat: Go profiling #7127
Merged
feat: Go profiling #7127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vaind is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
7 tasks
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@lizokm how do we test changes to |
aldy505
approved these changes
Jun 12, 2023
vivianyentran
approved these changes
Jun 12, 2023
|
@tonyo - it's a bit of a process. In your docs repo locally:
In your sentry repo locally: You should see the changes in the wizard when you create a new project |
shanamatthews
approved these changes
Jun 12, 2023
Co-authored-by: Shana Matthews <shana.l.matthews@gmail.com>
Co-authored-by: vivianyentran <20403606+vivianyentran@users.noreply.github.com>
|
Tested the wizard changes locally, works 👍 |
tonyo
pushed a commit
to getsentry/sentry
that referenced
this pull request
Jun 16, 2023
Related to getsentry/sentry-docs#7127 - adds Go Profiling wizard
priscilawebdev
pushed a commit
to getsentry/sentry
that referenced
this pull request
Jun 19, 2023
Related to getsentry/sentry-docs#7127 - adds Go Profiling wizard
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds relevant pages to the new Go Profiling alfa support introduced in getsentry/sentry-go#626
I've also adapted the
profiling-onboardingwizard but don't know how to check that locally...Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Extra resources