Skip to content

Commit

Permalink
Single profiler goroutine (#655)
Browse files Browse the repository at this point in the history
Co-authored-by: Michi Hoffmann <cleptric@users.noreply.github.com>
  • Loading branch information
vaind and cleptric committed Aug 18, 2023
1 parent 8b3833f commit 82a00ab
Show file tree
Hide file tree
Showing 9 changed files with 691 additions and 236 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Features

- Run single profiler even when profiling from multiple parallel goroutines ([#655](https://github.com/getsentry/sentry-go/pull/655))

### Bug fixes

- Fix trace function name parsing in profiler on go1.21+ ([#695](https://github.com/getsentry/sentry-go/pull/695))
Expand All @@ -11,6 +15,7 @@
The Sentry SDK team is happy to announce the immediate availability of Sentry Go SDK v0.23.0.

### Features

- Initial support for [Cron Monitoring](https://docs.sentry.io/product/crons/) ([#661](https://github.com/getsentry/sentry-go/pull/661))

This is how the basic usage of the feature looks like:
Expand Down Expand Up @@ -62,6 +67,7 @@ The Sentry SDK team is happy to announce the immediate availability of Sentry Go
- Expose SpanFromContext function ([#672](https://github.com/getsentry/sentry-go/pull/672))

### Bug fixes

- Make `Span.Finish` a no-op when the span is already finished ([#660](https://github.com/getsentry/sentry-go/pull/660))

## 0.22.0
Expand Down
9 changes: 4 additions & 5 deletions profile_sample.go
Expand Up @@ -28,7 +28,6 @@ type (

profileSample struct {
ElapsedSinceStartNS uint64 `json:"elapsed_since_start_ns"`
QueueAddress string `json:"queue_address,omitempty"`
StackID int `json:"stack_id"`
ThreadID uint64 `json:"thread_id"`
}
Expand All @@ -41,10 +40,10 @@ type (
profileStack []int

profileTrace struct {
Frames []*Frame `json:"frames"`
Samples []*profileSample `json:"samples"`
Stacks []profileStack `json:"stacks"`
ThreadMetadata map[string]profileThreadMetadata `json:"thread_metadata"`
Frames []*Frame `json:"frames"`
Samples []profileSample `json:"samples"`
Stacks []profileStack `json:"stacks"`
ThreadMetadata map[uint64]*profileThreadMetadata `json:"thread_metadata"`
}

profileInfo struct {
Expand Down

0 comments on commit 82a00ab

Please sign in to comment.