-
Notifications
You must be signed in to change notification settings - Fork 204
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Recover* report errors for any type of panic
The previous behavior was to silently stop panics without reporting to Sentry when the return value from recover() was not an error or a string. Runtime panics are specified to implement the predefined error interface, and string is probably the second most common type passed to panic() calls, still calls like panic(42) should not pass silently. This fix converts any other type to string using Go's standard formatting rules and reports the message to Sentry.
- Loading branch information
1 parent
fa9ada0
commit e1bfbd4
Showing
2 changed files
with
13 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters