Recover and RecoverWithContext with arbitrary types #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While Client.Recover and Client.RecoverWithContext are mostly meant to be internal methods called by methods with the same name on Hub, they are part of the exported API on Client. This commit avoids a runtime panic when those methods are called with a nil *EventHint.
kamilogorek
reviewed
Jul 20, 2020
This eliminates some code duplication. Note that it is important to keep the call to recover in the body of the function itself, because the Go spec defines that the return value of recover is (always) nil if it was not called directly by a deferred function.
The previous behavior was to silently stop panics without reporting to Sentry when the return value from recover() was not an error or a string. Runtime panics are specified to implement the predefined error interface, and string is probably the second most common type passed to panic() calls, still calls like panic(42) should not pass silently. This fix converts any other type to string using Go's standard formatting rules and reports the message to Sentry.
rhcarvalho
force-pushed
the
recover-arbitrary-types
branch
from
67627ed
to
e1bfbd4
Compare
kamilogorek
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #219.