feat: Add types and rename fields for tracing #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilogorek
previously approved these changes
Oct 16, 2020
|
I'm holding off merging this pending the direction that #285 takes. In particular, |
This overhauls the tracing-related types and their serialization to JSON. We rename Event.StartTimestamp, Span.StartTimestamp and Span.EndTimestamp to remove the "stamp" suffix in preparation to use StartTime and EndTime for spans when full tracing support is added. Preferring the shorter name because it is shorter and equally clear, and the type is time.Time. This is a breaking change, but should not affect most users, as those names were only used by the Sentry OpenTelemetry Exporter (we can update it) and are marked as experimental APIs.
rhcarvalho
force-pushed
the
renames-pre-tracing
branch
from
0c40025
to
18aaf7e
Compare
rhcarvalho
changed the title
|
@kamilogorek, sorry for the trouble. I've changed this PR to reflect changes in the initial tracing implementation, should still be easier to review than #285. |
HazAT
approved these changes
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This overhauls the tracing-related types and their serialization to
JSON.
We rename Event.StartTimestamp, Span.StartTimestamp and
Span.EndTimestamp to remove the "stamp" suffix in preparation to use
StartTime and EndTime for spans when full tracing support is added.
Preferring the shorter name because it is shorter and equally clear, and
the type is time.Time.
This is a breaking change, but should not affect most users, as those
names were only used by the Sentry OpenTelemetry Exporter (we can update
it) and are marked as experimental APIs.