Tracing examples #286
Closed
Tracing examples #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Rename Event.StartTimestamp, Span.StartTimestamp and Span.EndTimestamp to remove the "stamp" suffix in preparation to use StartTime and EndTime for spans when full tracing support is added. Preferring the shorter name because it is shorter and equally clear, and the type is time.Time. 2. Rename Span to RawSpan. Freeing up the name for the full tracing implementation where Span is an abstraction instead of the wire format. While this is theoretically a breaking change, it is one that should not affect users, as those names were only used internally by the Sentry OpenTelemetry Exporter (we can update it) and are marked as experimental APIs.
Closed
Closed
|
Decided to merge the initial examples with #285 so it's all in the same place. We may add more examples later, in which case we'll use new PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds upon #285 and contains some examples of how to use the new tracing APIs.
In practice, the relationship is the inverse. The examples were written first, before any implementation existed, as a way to inform and guide the new APIs exposed by the SDK.
As is the case with the implementation in #285, this is still a WIP draft.