Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add BeforeSendTransaction hook #517

Merged
merged 7 commits into from Jan 11, 2023
Merged

Conversation

tonyo
Copy link
Member

@tonyo tonyo commented Dec 19, 2022

BeforeSendTransaction works similarly to BeforeSend, but it is applied only to transaction events.

Closes #500.

Docs:

`beforeSendTransaction` works similarly to `beforeSend`, but it is
applied only to transaction events.
@tonyo tonyo self-assigned this Dec 19, 2022
@tonyo tonyo requested a review from cleptric December 20, 2022 16:47
Copy link
Member

@cleptric cleptric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there already a docs PR for this?

CHANGELOG.md Outdated

### Features

* Add `beforeSendTransaction` hook ([#517](https://github.com/getsentry/sentry-go/pull/517))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind adding a small snippet on how to use this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess adding a link that point to the docs (when they're ready) should be enough?
This change doesn't seem to be too important or breaking enough to cover it in the changelog.

Copy link
Member

@cleptric cleptric Jan 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like our changelogs to be a bit more telling, especially when it comes to new features. The Ruby SDK is a good benchmark we should aim for https://github.com/getsentry/sentry-ruby/releases

Maybe we could add the new hook to some example in the repo and point to it?
The docs are not very good at showing the actual use of this.

@tonyo
Copy link
Member Author

tonyo commented Jan 9, 2023

Added an example and updated the changelog.
Docs are pending for now, as described in getsentry/sentry-docs#6039

@tonyo tonyo requested a review from cleptric January 9, 2023 17:35
@tonyo tonyo changed the title feat: Add beforeSendTransaction hook feat: Add BeforeSendTransaction hook Jan 11, 2023
@tonyo tonyo merged commit 932dcf0 into master Jan 11, 2023
@tonyo tonyo deleted the tonyo/add-before-send-transaction branch January 11, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add beforeSendTransaction
2 participants