Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add DSN getters #540

Merged
merged 3 commits into from Jan 19, 2023
Merged

feat: Add DSN getters #540

merged 3 commits into from Jan 19, 2023

Conversation

cleptric
Copy link
Member

@cleptric cleptric commented Jan 19, 2023

Unsure about func (dsn Dsn) GetScheme() string instead of func (dsn Dsn) GetScheme() sheme.

I want to avoid exporting type scheme string though 🤔

This is needed for OTel (#537).

@cleptric cleptric self-assigned this Jan 19, 2023
@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Base: 84.01% // Head: 83.94% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (9d97cd6) compared to base (6b68090).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #540      +/-   ##
==========================================
- Coverage   84.01%   83.94%   -0.07%     
==========================================
  Files          23       23              
  Lines        2802     2816      +14     
==========================================
+ Hits         2354     2364      +10     
- Misses        367      370       +3     
- Partials       81       82       +1     
Impacted Files Coverage Δ
dsn.go 96.29% <100.00%> (+0.42%) ⬆️
integrations.go 89.01% <0.00%> (-2.32%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cleptric cleptric requested a review from tonyo January 19, 2023 12:16
@cleptric cleptric merged commit 4fad7b7 into master Jan 19, 2023
@cleptric cleptric deleted the cleptric/dsn branch January 19, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants