Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Span.SetData() #542

Merged
merged 2 commits into from Jan 23, 2023
Merged

feat: Add Span.SetData() #542

merged 2 commits into from Jan 23, 2023

Conversation

cleptric
Copy link
Member

This is needed for OTel (#537).

@cleptric cleptric changed the title feat: Add SetData feat: Add Span.SetData() Jan 22, 2023
@cleptric cleptric self-assigned this Jan 22, 2023
@codecov
Copy link

codecov bot commented Jan 22, 2023

Codecov Report

Base: 84.21% // Head: 84.24% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (ae107cf) compared to base (52e1547).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #542      +/-   ##
==========================================
+ Coverage   84.21%   84.24%   +0.02%     
==========================================
  Files          23       23              
  Lines        2820     2825       +5     
==========================================
+ Hits         2375     2380       +5     
+ Misses        365      364       -1     
- Partials       80       81       +1     
Impacted Files Coverage Δ
tracing.go 84.81% <100.00%> (+2.38%) ⬆️
integrations.go 89.01% <0.00%> (-2.32%) ⬇️
transport.go 77.80% <0.00%> (-1.41%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cleptric cleptric requested a review from tonyo January 22, 2023 20:55
@cleptric cleptric merged commit 946b556 into master Jan 23, 2023
@cleptric cleptric deleted the cleptric/set-data branch January 23, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants