Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump kataras/iris to 12.2.0-beta7 to resolve vulns #550

Closed
wants to merge 6 commits into from

Conversation

mdtro
Copy link
Member

@mdtro mdtro commented Jan 25, 2023

Bumps github.com/kataras/iris from v12.2.0-beta5 to v12.2.0-beta7 to resolve some transitive vulnerabilities.

Resolves:

The CHANGELOG for v12.2.0-beta7 can be found here.

@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Base: 78.80% // Head: 76.55% // Decreases project coverage by -2.26% ⚠️

Coverage data is based on head (dc2252f) compared to base (0a44c63).
Patch has no changes to coverable lines.

❗ Current head dc2252f differs from pull request most recent head 8719c6f. Consider uploading reports for the commit 8719c6f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #550      +/-   ##
==========================================
- Coverage   78.80%   76.55%   -2.26%     
==========================================
  Files          38       30       -8     
  Lines        3860     3387     -473     
==========================================
- Hits         3042     2593     -449     
+ Misses        714      697      -17     
+ Partials      104       97       -7     
Impacted Files Coverage Δ
internal/otel/baggage/baggage.go 44.05% <0.00%> (-53.50%) ⬇️
span_recorder.go 75.86% <0.00%> (-13.80%) ⬇️
interfaces.go 93.22% <0.00%> (-0.12%) ⬇️
otel/span_map.go
otel/internal/utils/sentryrequest.go
internal/testutils/asserts.go
otel/propagator.go
otel/span_processor.go
otel/internal/utils/spanattributes.go
otel/event_processor.go
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tonyo
Copy link
Member

tonyo commented Jan 25, 2023

Hey @mdtro , for additional context, could you link to the changelog, and/or vulnerability report please?

@mdtro
Copy link
Member Author

mdtro commented Jan 25, 2023

Hey @mdtro , for additional context, could you link to the changelog, and/or vulnerability report please?

Done! Apologies for not including it to begin with. 🙂

Copy link
Member

@tonyo tonyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🏄

Copy link
Member

@cleptric cleptric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep in mind that we're forcing Sentry users to upgrade iris by merging this.
This is kinda against our philosophy, but we got a lot of complaints about the Go SDK triggering some false positives in weird security scanners.

@mdtro
Copy link
Member Author

mdtro commented Jan 25, 2023

Please keep in mind that we're forcing Sentry users to upgrade iris by merging this. This is kinda against our philosophy, but we got a lot of complaints about the Go SDK triggering some false positives in weird security scanners.

@cleptric I understand the concern. We are only moving from beta5 to beta7, but that definitely moves a lot of the indirect dependencies forward quite a few versions.

I second the SDKs generating false positives in the various security scanners. I used three different ones and ended up with three different answers. 🙃

v12.2.0-beta7 was released just over 30 days ago, so we want to wait a bit longer for any bugs to surface -- I think that's reasonable.

@github-actions

This comment was marked as outdated.

@cleptric
Copy link
Member

Let's bite the bullet 😄

@cleptric cleptric enabled auto-merge (squash) February 16, 2023 12:38
@mdtro
Copy link
Member Author

mdtro commented Feb 17, 2023

Ooph, the checks aren't happy. I'll add this to my list to dig in on early next week.

@github-actions
Copy link

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@cleptric
Copy link
Member

Part of #595

@cleptric cleptric closed this Mar 20, 2023
@cleptric cleptric deleted the mdtro/iris-12.2.0-beta7 branch March 20, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants