feat: Remove store endpoint #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleptric
force-pushed
the
remove-store-endpoint
branch
from
3843b0a
to
ae31404
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #631 +/- ##
==========================================
- Coverage 79.86% 79.66% -0.21%
==========================================
Files 38 38
Lines 3889 3885 -4
==========================================
- Hits 3106 3095 -11
- Misses 675 681 +6
- Partials 108 109 +1
☔ View full report in Codecov by Sentry. |
tonyo
approved these changes
May 8, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To move forward on initiatives like https://github.com/getsentry/team-replay/issues/70 and getsentry/team-webplatform-meta#45, we decided to remove the
/storeendpoint from the Go SDK.These changes require a self-hosted version of Sentry 20.6.0 or higher. If you are using a version of self-hosted Sentry (aka onpremise) older than 20.6.0 then you will need to upgrade.
I removed quite a few things from
logrusentry_test.go.My reasoning is that we mostly care about testing
entryToEvent, as all other functionality is wrapped intoCaptureEvent. Making the tests work again would require copying a lot of functionality fromclient_test.go, something I'm not keen on maintaining.