fix: Improve isSentryRequestUrl #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #632 +/- ##
==========================================
+ Coverage 79.90% 79.94% +0.03%
==========================================
Files 38 38
Lines 3887 3889 +2
==========================================
+ Hits 3106 3109 +3
Misses 673 673
+ Partials 108 107 -1
☔ View full report in Codecov by Sentry. |
tonyo
approved these changes
May 4, 2023
| @@ -27,7 +27,10 @@ func IsSentryRequestSpan(ctx context.Context, s trace.ReadOnlySpan) bool { | |||
| func isSentryRequestUrl(ctx context.Context, url string) bool { | |||
| hub := sentry.GetHubFromContext(ctx) | |||
| if hub == nil { | |||
| return false | |||
| hub = sentry.CurrentHub() | |||
There was a problem hiding this comment.
Note: for better experience and to fix more cases like this, we might want to set the Hub on context a lot earlier, maybe even in StartSpan.
There was a problem hiding this comment.
We might not know which hub to set on the ctx in StartSpan.
I think it might be worth digging a little bit into how Otel handles go routines.
For now, we might still consider this as a quick win.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we can't fetch a hub from the
ctx, we now fallback to the global hub.I also added the project id to not solely rely on the hostname.