Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tracing): Make Span.Finish a no-op when the span is already finished #660

Merged
merged 4 commits into from Jul 5, 2023

Merge branch 'master' into tonyo/feat-span-finish-only-once

668b4ff
Select commit
Failed to load commit list.
Merged

fix(tracing): Make Span.Finish a no-op when the span is already finished #660

Merge branch 'master' into tonyo/feat-span-finish-only-once
668b4ff
Select commit
Failed to load commit list.
Codecov / codecov/project succeeded Jul 5, 2023 in 0s

80.60% (-0.01%) compared to 1b2ac13

View this Pull Request on Codecov

80.60% (-0.01%) compared to 1b2ac13

Details

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (1b2ac13) 80.61% compared to head (668b4ff) 80.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #660      +/-   ##
==========================================
- Coverage   80.61%   80.60%   -0.01%     
==========================================
  Files          43       43              
  Lines        4338     4337       -1     
==========================================
- Hits         3497     3496       -1     
  Misses        714      714              
  Partials      127      127              
Impacted Files Coverage Δ
tracing.go 86.13% <100.00%> (-0.03%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.