Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tracing): Add the sampling decision to the trace envelope header #666

Merged
merged 1 commit into from Jul 11, 2023
Merged

feat(tracing): Add the sampling decision to the trace envelope header #666

merged 1 commit into from Jul 11, 2023

Conversation

cleptric
Copy link
Member

@cleptric cleptric commented Jul 11, 2023 •
edited

Closes #665

@cleptric cleptric self-assigned this Jul 11, 2023
@cleptric cleptric requested a review from tonyo July 11, 2023 09:14
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (6db2fc7) 80.60% compared to head (6540509) 80.60%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #666      +/-   ##
==========================================
- Coverage   80.60%   80.60%   -0.01%     
==========================================
  Files          43       43              
  Lines        4337     4342       +5     
==========================================
+ Hits         3496     3500       +4     
- Misses        714      715       +1     
  Partials      127      127
Impacted Files Coverage Δ
dynamic_sampling_context.go 93.67% <100.00%> (+0.42%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tonyo tonyo changed the title Add the sampling decision to the trace envelope header feat(tracing): Add the sampling decision to the trace envelope header Jul 11, 2023
@cleptric cleptric merged commit b6dfea7 into master Jul 11, 2023
14 checks passed
@cleptric cleptric deleted the dsc-sampled branch July 11, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyo tonyo tonyo approved these changes

Assignees

@cleptric cleptric

Labels
Status: In Progress Type: Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Sampling Decision to Trace Envelope Header
2 participants
@cleptric @tonyo