Set SDK Name According Framework being used #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #694 +/- ##
==========================================
- Coverage 80.78% 80.70% -0.08%
==========================================
Files 45 45
Lines 4574 4598 +24
==========================================
+ Hits 3695 3711 +16
- Misses 742 750 +8
Partials 137 137
☔ View full report in Codecov by Sentry. |
cleptric
commented
Aug 9, 2023
cleptric
commented
Aug 9, 2023
| @@ -209,7 +209,8 @@ func envelopeFromBody(event *Event, dsn *Dsn, sentAt time.Time, body json.RawMes | |||
| func getRequestFromEvent(event *Event, dsn *Dsn) (r *http.Request, err error) { | |||
| defer func() { | |||
| if r != nil { | |||
| r.Header.Set("User-Agent", userAgent) | |||
| r.Header.Set("User-Agent", fmt.Sprintf("%s/%s", event.Sdk.Name, event.Sdk.Version)) | |||
| r.Header.Set("Content-Type", "application/x-sentry-envelope") | |||
There was a problem hiding this comment.
cleptric
commented
Aug 9, 2023
dsn.go
Outdated
| @@ -197,6 +197,7 @@ func (dsn Dsn) GetAPIURL() *url.URL { | |||
| } | |||
|
|
|||
| // RequestHeaders returns all the necessary headers that have to be used in the transport. | |||
| // Deprecated: To be removed in 0.25.0. Requests to /envelope are authenticated using the DSN in the envelope header itself. | |||
There was a problem hiding this comment.
tonyo
approved these changes
Aug 10, 2023
# Conflicts: # client_test.go
tonyo
approved these changes
Aug 29, 2023
Co-authored-by: Anton Ovchinnikov <anton@tonyo.info>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #685