Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Read release info from build info #704

Merged
merged 3 commits into from Sep 1, 2023
Merged

feat: Read release info from build info #704

merged 3 commits into from Sep 1, 2023

Commits on Aug 30, 2023

  1. Read release info from build info 

    Since go1.18, vcs.revision gets compiled into the binary and can be
read.

Conveniently, debug.ReadBuildInfo has been around since go1.12, so
there's no need to conditionally compile this unless sentry-go needs to
support < go1.12 for some reason.

So in builds newer than 1.18, this key just simply won't exist and
effectively will do nothing.

This is much more convenient to detect in anything go1.18 since it's
much more common to have this compiled in.
    @mattrobenolt @DAcodedBEAT
    mattrobenolt authored and DAcodedBEAT committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    d9f25b3 View commit details
    Browse the repository at this point in the history

  2. refactor build info collection to unit test, add unit tests for using… 

    … debug.ReadBuildInfo for release
    @DAcodedBEAT
    DAcodedBEAT committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    3a938c6 View commit details
    Browse the repository at this point in the history

  3. use builtin t.Setenv instead of custom envSetter helper

    @DAcodedBEAT
    DAcodedBEAT committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    434cad0 View commit details
    Browse the repository at this point in the history