fix(otel): prevent panic in shutdown #711
Conversation
Shutdown panics when passed a background context, or any context which doesn't contain a hub. Returning the current hub if no hub is found on the context prevents this.
greywolve
force-pushed
the
fix-shutdown-panic
branch
from
c42267d
to
d5af2c1
Compare
| @@ -103,6 +103,10 @@ func (ssp *sentrySpanProcessor) ForceFlush(ctx context.Context) error { | |||
|
|
|||
| func flushSpanProcessor(ctx context.Context) error { | |||
There was a problem hiding this comment.
I guess one question is if anyone is actually going to pass a context in here that contains a hub?
Seems more like this will almost always be something like context.Background() with no hub. I think the original purpose here, at least looking at the otel project, is to allow the user to pass in a context with a timeout. The flush method though already has a timeout, so context passed here isn't really useful to us.
There was a problem hiding this comment.
You're right, it's not ideal, and relying on people passing the right context is not a good approach.
It might be still good to let people pass sentry.Hub via context (for more flexibility, and maybe in the future allowing multiple span processor instances?), so your fix should be good for now 👍
Shutdown panics when passed a background context, or any context which doesn't contain a hub. Returning the current hub if no hub is found on the context prevents this.
Fixes #692