Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: global tags #718

Merged
merged 7 commits into from Sep 26, 2023
Merged

feat: global tags #718

merged 7 commits into from Sep 26, 2023

Conversation

greywolve
Copy link
Contributor

Add global tags support.

Tags can be passed via client options or via environment variables by prefixing them with "SENTRY_TAGS_".

Setting scope tags overrides global tags.

Client option tags override environment variable tags.

Fixes: #331

Add global tags support.

Tags can be passed via client options or via environment variables by
prefixing them with "SENTRY_TAGS_".

Setting scope tags overrides global tags.

Client option tags override environment variable tags.
client.go Outdated Show resolved Hide resolved
@greywolve
Copy link
Contributor Author

greywolve commented Sep 19, 2023

Hmm seems tests are failing from an empty map being present instead of nil. I'll fix.

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage is 91.66% of modified lines.

Files Changed Coverage
integrations.go 91.42%
client.go 100.00%

📢 Thoughts on this report? Let us know!.

integrations.go Outdated Show resolved Hide resolved
integrations.go Show resolved Hide resolved
@greywolve
Copy link
Contributor Author

@tonyo comments addressed. :)

Copy link
Member

@tonyo tonyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed another small thing, otherwise LGTM 👍

integrations.go Outdated Show resolved Hide resolved
Copy link
Member

@cleptric cleptric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@cleptric cleptric merged commit 68e2c0f into getsentry:master Sep 26, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SENTRY_TAGS_* environment variables
3 participants