Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stacktrace): support package name parsing for Go 1.20+ #730

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

greywolve
Copy link
Contributor

Go 1.20+ changed reserved prefixes for compiler-generated symbols from "go." and "type." to "go:" and "type:" respectively.

See: golang/go@0f8dffd

This adds support for both kinds of compiler-generated symbols depending on the Go version by taking advantage of build tags.

Fixes #180

Inspired by and continued on from: #707

Go 1.20+ changed reserved prefixes for compiler-generated symbols from
"go." and "type." to "go:" and "type:" respectively.

See: golang/go@0f8dffd

This adds support for both kinds of compiler-generated symbols depending
on the Go version by taking advantage of build tags.
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
stacktrace.go 84.57% <100.00%> (+1.24%) ⬆️
stacktrace_below_go1.20.go 100.00% <100.00%> (ø)
stacktrace_go1.20.go 100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

@GregBrimble
Copy link

Thanks! Appreciate you picking that up for me. I'll close mine out.

Copy link
Member

@cleptric cleptric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@cleptric cleptric merged commit 592c7db into getsentry:master Oct 9, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stacktrace for functions from "go.*" will have incorrect package name
3 participants