fix: Create word-based fidelity source mapping for code transformations #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
approved these changes
Apr 2, 2024
lforst
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix #512
It seems like we are OOMing users with the plugin. I previously wrote this off as an upstream issue, but looking at the comment #379 (comment) which narrows the OOM issue down to version 2.7.0 or 2.7.1, it seems like #383 could have introduced memory issues since
hires: truewill create mappings for every single character.Now that I am wiser I don't think that is entirely necesary - especially for our use-case. Let's see if removing that option would fix it. It looks like simply removing
hires: truewill drastically reduce the fidelity of source maps to line based mappings, however, a newer release ofmagic-stringincludes a new option value'boundary'which does word-based mapping. I hope this will reduce memory pressure while still preserving high quality source maps.