Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(publish): Add version bump script #53

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Oct 19, 2022

This PR (unfortunately) adds lerna to our repo to use it as a mechanism of bumping all our package versions. We need this for the craft publishing process.

For future readers, here are some reasons for choosing lerna:

  • Nx doesn't have a version bump command built in :(
  • I tried to use the Nx semVer plugin but this tool does too much for our purposes
    • it creates git tags (can't disable this)
    • it automatically determines if the version should be a major/minor/patch bump
    • we could only manually override the decision to bump to the next major/minor/patch but we can't just specify a version.
    • Because of these limitations and for time reasons we chose not to pursue this approach further
  • I tried to use yarn version but this would only bump the version of the respective package, but not of the package's dependencies.
    • This caused yarn install failures because of dependency missmatches after bumping the versions.

Lerna has a lerna version command which lets us set a specific version on our terms. So we're welcoming it back for now until Nx hopefully figures this out.

Furthermore, the PR adds a pre-release script we need for craft later on

ref #50

@Lms24 Lms24 requested a review from lforst October 20, 2022 08:13
@Lms24 Lms24 merged commit 77a217e into main Oct 20, 2022
@Lms24 Lms24 deleted the lms-bump-version-lerna branch October 20, 2022 11:04
@AbhiPrasad
Copy link
Member

Maybe one day we try https://rushjs.io/ - which has this stuff built in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants