Skip to content

Commit

Permalink
ref(remix): Add transaction source (#5398)
Browse files Browse the repository at this point in the history
  • Loading branch information
AbhiPrasad committed Jul 11, 2022
1 parent 014fcf0 commit 2c6683f
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 2 deletions.
8 changes: 7 additions & 1 deletion packages/remix/src/performance/client.tsx
Expand Up @@ -66,6 +66,9 @@ export function remixRouterInstrumentation(useEffect: UseEffect, useLocation: Us
name: initPathName,
op: 'pageload',
tags: DEFAULT_TAGS,
metadata: {
source: 'url',
},
});
}

Expand Down Expand Up @@ -114,7 +117,7 @@ export function withSentry<P extends Record<string, unknown>, R extends React.FC

_useEffect(() => {
if (activeTransaction && matches && matches.length) {
activeTransaction.setName(matches[matches.length - 1].id);
activeTransaction.setName(matches[matches.length - 1].id, 'route');
}

isBaseLocation = true;
Expand All @@ -138,6 +141,9 @@ export function withSentry<P extends Record<string, unknown>, R extends React.FC
name: matches[matches.length - 1].id,
op: 'navigation',
tags: DEFAULT_TAGS,
metadata: {
source: 'route',
},
});
}
}, [location]);
Expand Down
3 changes: 3 additions & 0 deletions packages/remix/src/utils/instrumentServer.ts
Expand Up @@ -183,6 +183,9 @@ function wrapRequestHandler(origRequestHandler: RequestHandler): RequestHandler
tags: {
method: request.method,
},
metadata: {
source: 'url',
},
});

if (transaction) {
Expand Down
2 changes: 1 addition & 1 deletion packages/types/src/transaction.ts
Expand Up @@ -72,7 +72,7 @@ export interface Transaction extends TransactionContext, Span {
/**
* Set the name of the transaction
*/
setName(name: string): void;
setName(name: string, source?: TransactionMetadata['source']): void;

/**
* Set observed measurement for this transaction.
Expand Down

0 comments on commit 2c6683f

Please sign in to comment.