Feat: Add @sentry/tracing #2719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
force-pushed
the
abhi/ref/add-sentry-tracing
branch
from
ab7d985
to
14eba60
Compare
AbhiPrasad
force-pushed
the
abhi/ref/add-sentry-tracing
branch
from
8906f3a
to
ef59276
Compare
HazAT
reviewed
Jul 13, 2020
* feat: Adjust hub for idle transaction * feat: Add IdleTransaction class * test: IdleTransaction * ref: Some uneeded code * ref: Declare class variables in constructor * chore: Cleanup set() comments
* test: remove hub.startSpan test * feat(tracing): Add BrowserTracing integration and tests * fix: defaultRoutingInstrumentation * ref: Remove static methods * multiple before finishes * ref: Routing Instrumentation * remove tracing
* ref: Make React Profiler use active transaction * ref: Make Vue Tracing using active transaction
AbhiPrasad
force-pushed
the
abhi/ref/add-sentry-tracing
branch
from
eb3917e
to
2c88eb9
Compare
HazAT
requested changes
Jul 15, 2020
AbhiPrasad
force-pushed
the
abhi/ref/add-sentry-tracing
branch
from
5ffffd8
to
fee0ec2
Compare
AbhiPrasad
commented
Jul 15, 2020
|
|
||
| This package contains extensions to the `@sentry/hub` to enable Sentry AM related functionality. It also provides integrations for Browser and Node that provide a good experience out of the box. | ||
|
|
||
| ## Migrating from @sentry/apm to @sentry/tracing |
There was a problem hiding this comment.
This is the migration guide, does this make sense?
| export { INTEGRATIONS as Integrations }; | ||
|
|
||
| // We are patching the global object with our hub extension methods | ||
| addExtensionMethods(); |
There was a problem hiding this comment.
We still have to move this into an option, but I'll save that for another PR.
Something like
Sentry.init({
extensions: [apm]
})
There was a problem hiding this comment.
Let's deal with it on a follow up PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create
@sentry/tracing. This is what I will work off as we making our refactors to theTracingintegration.I figured we should merge this in first so that we can concurrently work on it together.